net: bridge: mst: fix suspicious rcu usage in br_mst_set_state

BugLink: https://bugs.launchpad.net/bugs/2074091

[ Upstream commit 546ceb1dfdac866648ec959cbc71d9525bd73462 ]

I converted br_mst_set_state to RCU to avoid a vlan use-after-free
but forgot to change the vlan group dereference helper. Switch to vlan
group RCU deref helper to fix the suspicious rcu usage warning.

Fixes: 3a7c1661ae13 ("net: bridge: mst: fix vlan use-after-free")
Reported-by: syzbot+9bbe2de1bc9d470eb5fe@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=9bbe2de1bc9d470eb5fe
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://lore.kernel.org/r/20240609103654.914987-3-razor@blackwall.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Portia Stephens <portia.stephens@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>

This commit is contained in:

Nikolay Aleksandrov

2024-06-09 13:36:54 +03:00

committed by

Roxana Nicolescu

parent b240a0e478

commit f7853a0194

1 changed files with 1 additions and 1 deletions

									
										net/bridge/br_mst.c
									
		+1
		-1
	
												View File
												
				@@ -102,7 +102,7 @@ int br_mst_set_state(struct net_bridge_port *p, u16 msti, u8 state,

					int err = 0;

					rcu_read_lock();

					vg = nbp_vlan_group(p);

					vg = nbp_vlan_group_rcu(p);

					if (!vg)

						goto out;