tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powercap: dtpm_cpu: Fix error check against freq_qos_add_request()

Browse Source 
BugLink: https://bugs.launchpad.net/bugs/2060097

[ Upstream commit b50155cb0d609437236c88201206267835c6f965 ]

The caller of the function freq_qos_add_request() checks again a non
zero value but freq_qos_add_request() can return '1' if the request
already exists. Therefore, the setup function fails while the QoS
request actually did not failed.

Fix that by changing the check against a negative value like all the
other callers of the function.

Fixes: 0e8f68d7f0 ("Add CPU energy model based support")
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit e53f6a685c6b88a62db65e3551599dd36b646ab5)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
This commit is contained in:
Daniel Lezcano
2024-02-13 23:39:47 +01:00
committed by Roxana Nicolescu
parent 412ecffa2a
commit e859804001
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/powercap/dtpm_cpu.c
+1 -1
View File
@@ -219,7 +219,7 @@ static int __dtpm_cpu_setup(int cpu, struct dtpm *parent)
ret = freq_qos_add_request(&policy->constraints,
&dtpm_cpu->qos_req, FREQ_QOS_MAX,
pd->table[pd->nr_perf_states - 1].frequency);
if (ret)
if (ret < 0)
goto out_dtpm_unregister;
cpufreq_cpu_put(policy);