tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NVIDIA: SAUCE: PCI: designware-host: Update resource cleanup

Browse Source 
BugLink: https://bugs.launchpad.net/bugs/2072591

Config space is mapped on every host init, however, its free'ed
only when corresponding device is unbinded. During hotplug, host
init is called multiple times causing mapping issues. So map
config space only if its not mapped previously.

Similarly during deinit, bridge resources are not freed, release the
same.

http://nvbugs/3868928

Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com>
Reviewed-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Reviewed-by: Bitan Biswas <bbiswas@nvidia.com>
Tested-by: Abhilash G <abhilashg@nvidia.com>
Reviewed-by: Abhilash G <abhilashg@nvidia.com>
Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Acked-by: Jacob Martin <jacob.martin@canonical.com>
Acked-by: Noah Wager <noah.wager@canonical.com>
Signed-off-by: Noah Wager <noah.wager@canonical.com>
This commit is contained in:
Nagarjuna Kristam
2022-11-14 10:48:53 +05:30
committed by Noah Wager
parent 8f4eb64efc
commit e6085c8606
1 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/pci/controller/dwc/pcie-designware-host.c
+22 -3
View File
@@ -415,9 +415,11 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)
pp->cfg0_size = resource_size(res);
pp->cfg0_base = res->start;
pp->va_cfg0_base = devm_pci_remap_cfg_resource(dev, res);
if (IS_ERR(pp->va_cfg0_base))
return PTR_ERR(pp->va_cfg0_base);
if (!pp->va_cfg0_base) {
pp->va_cfg0_base = devm_pci_remap_cfg_resource(dev, res);
if (IS_ERR(pp->va_cfg0_base))
return PTR_ERR(pp->va_cfg0_base);
}
} else {
dev_err(dev, "Missing *config* reg space\n");
return -ENODEV;
@@ -533,6 +535,8 @@ EXPORT_SYMBOL_GPL(dw_pcie_host_init);
void dw_pcie_host_deinit(struct dw_pcie_rp *pp)
{
struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
struct device *dev = pci->dev;
struct resource_entry *win, *tmp;
pci_stop_root_bus(pp->bridge->bus);
pci_remove_root_bus(pp->bridge->bus);
@@ -546,6 +550,21 @@ void dw_pcie_host_deinit(struct dw_pcie_rp *pp)
if (pp->ops->deinit)
pp->ops->deinit(pp);
resource_list_for_each_entry_safe(win, tmp, &pp->bridge->windows) {
switch (resource_type(win->res)) {
case IORESOURCE_IO:
pci_unmap_iospace(win->res);
devm_release_resource(dev, win->res);
break;
case IORESOURCE_MEM:
devm_release_resource(dev, win->res);
break;
default:
continue;
}
}
pci_free_host_bridge(pp->bridge);
}
EXPORT_SYMBOL_GPL(dw_pcie_host_deinit);