net: af_can: do not leave a dangling sk pointer in can_create()

BugLink: https://bugs.launchpad.net/bugs/2102118

[ Upstream commit 811a7ca7320c062e15d0f5b171fe6ad8592d1434 ]

On error can_create() frees the allocated sk object, but sock_init_data()
has already attached it to the provided sock object. This will leave a
dangling sk pointer in the sock object and may cause use-after-free later.

Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://patch.msgid.link/20241014153808.51894-5-ignat@cloudflare.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
CVE-2024-56603
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

This commit is contained in:

Ignat Korchagin

2025-03-12 22:51:00 +09:00

committed by

Stefan Bader

parent 70b7ebafce

commit e2a226db54

1 changed files with 1 additions and 0 deletions

									
										net/can/af_can.c
									
		+1
		
												View File
												
				@@ -171,6 +171,7 @@ static int can_create(struct net *net, struct socket *sock, int protocol,

						/* release sk on errors */

						sock_orphan(sk);

						sock_put(sk);

						sock->sk = NULL;

					}

				 errout: