tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ALSA: control: Avoid WARN() for symlink errors

Browse Source 
BugLink: https://bugs.launchpad.net/bugs/2102181

[ Upstream commit b2e538a9827dd04ab5273bf4be8eb2edb84357b0 ]

Using WARN() for showing the error of symlink creations don't give
more information than telling that something goes wrong, since the
usual code path is a lregister callback from each control element
creation.  More badly, the use of WARN() rather confuses fuzzer as if
it were serious issues.

This patch downgrades the warning messages to use the normal dev_err()
instead of WARN().  For making it clearer, add the function name to
the prefix, too.

Fixes: a135dfb5de ("ALSA: led control - add sysfs kcontrol LED marking layer")
Reported-by: syzbot+4e7919b09c67ffd198ae@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/675664c7.050a0220.a30f1.018c.GAE@google.com
Link: https://patch.msgid.link/20241209095614.4273-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
CVE-2024-56657
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Mehmet Basaran <mehmet.basaran@canonical.com>
This commit is contained in:
Takashi Iwai
2025-03-13 13:21:44 +09:00
committed by Mehmet Basaran
parent 3dd9b8e67c
commit df5efb1034
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sound/core/control_led.c
+10 -4
View File
@@ -688,10 +688,16 @@ static void snd_ctl_led_sysfs_add(struct snd_card *card)
goto cerr;
led->cards[card->number] = led_card;
snprintf(link_name, sizeof(link_name), "led-%s", led->name);
WARN(sysfs_create_link(&card->ctl_dev->kobj, &led_card->dev.kobj, link_name),
"can't create symlink to controlC%i device\n", card->number);
WARN(sysfs_create_link(&led_card->dev.kobj, &card->card_dev.kobj, "card"),
"can't create symlink to card%i\n", card->number);
if (sysfs_create_link(&card->ctl_dev->kobj, &led_card->dev.kobj,
link_name))
dev_err(card->dev,
"%s: can't create symlink to controlC%i device\n",
__func__, card->number);
if (sysfs_create_link(&led_card->dev.kobj, &card->card_dev.kobj,
"card"))
dev_err(card->dev,
"%s: can't create symlink to card%i\n",
__func__, card->number);
continue;
cerr: