tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

printk: nbcon: Use driver synchronization while registering

Browse Source 
BugLink: https://bugs.launchpad.net/bugs/2060704

Depending on if an nbcon console is registered, a driver may
handle its internal locking differently. If a driver is holding
its internal lock while the nbcon console is registered, there
may be a risk that two different contexts access the hardware
simultaneously without synchronization. (For example, if the
printk subsystem invokes atomic printing while another driver
context acquired the internal lock without considering the
atomic console.)

Use the driver synchronization while a registering nbcon console
transitions to being registered. This guarantees that if the
driver acquires its internal lock when the nbcon console was not
registered, it will remain unregistered until that context
releases the lock.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Kevin Becker <kevin.becker@canonical.com>
This commit is contained in:
John Ogness
2024-03-15 15:38:22 +00:00
committed by Kevin Becker
parent 3a5c4daac8
commit be656d0beb
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
kernel/printk/printk.c
+18
View File
@@ -3474,6 +3474,7 @@ void register_console(struct console *newcon)
struct console *con;
bool bootcon_registered = false;
bool realcon_registered = false;
unsigned long flags;
int err;
console_list_lock();
@@ -3565,6 +3566,19 @@ void register_console(struct console *newcon)
newcon->seq = 0;
}
/*
* If another context is actively using the hardware of this new
* console, it will not be aware of the nbcon synchronization. This
* is a risk that two contexts could access the hardware
* simultaneously if this new console is used for atomic printing
* and the other context is still using the hardware.
*
* Use the driver synchronization to ensure that the hardware is not
* in use while this new console transitions to being registered.
*/
if ((newcon->flags & CON_NBCON) && newcon->write_atomic)
newcon->device_lock(newcon, &flags);
/*
* Put this console in the list - keep the
* preferred driver at the head of the list.
@@ -3589,6 +3603,10 @@ void register_console(struct console *newcon)
* register_console() completes.
*/
/* This new console is now registered. */
if ((newcon->flags & CON_NBCON) && newcon->write_atomic)
newcon->device_unlock(newcon, flags);
console_sysfs_notify();
/*