driver core: bus: Fix double free in driver API bus_register()
BugLink: https://bugs.launchpad.net/bugs/2097301 [ Upstream commit bfa54a793ba77ef696755b66f3ac4ed00c7d1248 ] For bus_register(), any error which happens after kset_register() will cause that @priv are freed twice, fixed by setting @priv with NULL after the first free. Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com> Link: https://lore.kernel.org/r/20240727-bus_register_fix-v1-1-fed8dd0dba7a@quicinc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> CVE-2024-50055 Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com> Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
This commit is contained in:
@@ -920,6 +920,8 @@ bus_devices_fail:
|
||||
bus_remove_file(bus, &bus_attr_uevent);
|
||||
bus_uevent_fail:
|
||||
kset_unregister(&priv->subsys);
|
||||
/* Above kset_unregister() will kfree @priv */
|
||||
priv = NULL;
|
||||
out:
|
||||
kfree(priv);
|
||||
return retval;
|
||||
|
||||
Reference in New Issue
Block a user