drm/xe: Check pat.ops before dumping PAT settings

BugLink: https://bugs.launchpad.net/bugs/2076435

[ Upstream commit a918e771e6fbe1fa68932af5b0cdf473e23090cc ]

We may leave pat.ops unset when running on brand new platform or
when running as a VF.  While the former is unlikely, the latter
is valid (future) use case and will cause NPD when someone will
try to dump PAT settings by debugfs.

It's better to check pointer to pat.ops instead of specific .dump
hook, as we have this hook always defined for every .ops variant.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240409105106.1067-2-michal.wajdeczko@intel.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Portia Stephens <portia.stephens@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>

This commit is contained in:

Michal Wajdeczko

2024-04-09 12:51:06 +02:00

committed by

Stefan Bader

parent 755b904aef

commit bbca7e7f9d

1 changed files with 1 additions and 1 deletions

									
										drivers/gpu/drm/xe/xe_pat.c
									
		+1
		-1
	
												View File
												
				@@ -452,7 +452,7 @@ void xe_pat_dump(struct xe_gt *gt, struct drm_printer *p)

				{

					struct xe_device *xe = gt_to_xe(gt);

					if (!xe->pat.ops->dump)

					if (!xe->pat.ops)

						return;

					xe->pat.ops->dump(gt, p);