firmware: qcom: uefisecapp: Fix deadlock in qcuefi_acquire()

BugLink: https://bugs.launchpad.net/bugs/2086138

[ Upstream commit db213b0cfe3268d8b1d382b3bcc999c687a2567f ]

If the __qcuefi pointer is not set, then in the original code, we would
hold onto the lock.  That means that if we tried to set it later, then
it would cause a deadlock.  Drop the lock on the error path.  That's
what all the callers are expecting.

Fixes: 759e7a2b62 ("firmware: Add support for Qualcomm UEFI Secure Application")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/19829bc4-1b6f-47f7-847a-e90c25749e40@stanley.mountain
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>

This commit is contained in:

Dan Carpenter

2024-08-29 22:23:04 +03:00

committed by

Mehmet Basaran

parent 3684c6a9c6

commit a36121d985

1 changed files with 4 additions and 0 deletions

									
										drivers/firmware/qcom/qcom_qseecom_uefisecapp.c
									
		+4
		
												View File
												
				@@ -786,6 +786,10 @@ static int qcuefi_set_reference(struct qcuefi_client *qcuefi)

				static struct qcuefi_client *qcuefi_acquire(void)

				{

					mutex_lock(&__qcuefi_lock);

					if (!__qcuefi) {

						mutex_unlock(&__qcuefi_lock);

						return NULL;

					}

					return __qcuefi;

				}