qibfs: fix dentry leak

BugLink: https://bugs.launchpad.net/bugs/2070349

[ Upstream commit aa23317d0268b309bb3f0801ddd0d61813ff5afb ]

simple_recursive_removal() drops the pinning references to all positives
in subtree.  For the cases when its argument has been kept alive by
the pinning alone that's exactly the right thing to do, but here
the argument comes from dcache lookup, that needs to be balanced by
explicit dput().

Fixes: e41d237818 "qib_fs: switch to simple_recursive_removal()"
Fucked-up-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

This commit is contained in:

Al Viro

2024-02-25 23:58:42 -05:00

committed by

Stefan Bader

parent f8f0b31cb2

commit 96b070b58b

1 changed files with 1 additions and 0 deletions

									
										drivers/infiniband/hw/qib/qib_fs.c
									
		+1
		
												View File
												
				@@ -439,6 +439,7 @@ static int remove_device_files(struct super_block *sb,

						return PTR_ERR(dir);

					}

					simple_recursive_removal(dir, NULL);

					dput(dir);

					return 0;

				}