ice: Do not call ice_finalize_xdp_rx() unnecessarily

Currently ice_finalize_xdp_rx() is called only when xdp_prog is present
on VSI, which is a good thing. However, this optimization can be
enhanced and check only if any of the XDP_TX/XDP_REDIRECT took place in
current Rx processing. Non-zero value of @xdp_xmit indicates that
xdp_prog is present on VSI. This way XDP_DROP-based workloads will not
suffer from unnecessary calls to external function.

Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Link: https://lore.kernel.org/bpf/20230131204506.219292-9-maciej.fijalkowski@intel.com
This commit is contained in:
Maciej Fijalkowski
2023-01-31 21:45:01 +01:00
committed by Daniel Borkmann
parent 60bc72b3c4
commit 9070fe3da0
+1 -1
View File
@@ -1252,7 +1252,7 @@ construct_skb:
/* return up to cleaned_count buffers to hardware */
failure = ice_alloc_rx_bufs(rx_ring, cleaned_count);
if (xdp_prog)
if (xdp_xmit)
ice_finalize_xdp_rx(xdp_ring, xdp_xmit);
rx_ring->skb = skb;