thermal/drivers/qcom/lmh: Check for SCM availability at probe

BugLink: https://bugs.launchpad.net/bugs/2073788

commit d9d3490c48df572edefc0b64655259eefdcbb9be upstream.

Up until now, the necessary scm availability check has not been
performed, leading to possible null pointer dereferences (which did
happen for me on RB1).

Fix that.

Fixes: 53bca371cd ("thermal/drivers/qcom: Add support for LMh driver")
Cc: <stable@vger.kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20240308-topic-rb1_lmh-v2-2-bac3914b0fe3@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Portia Stephens <portia.stephens@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>

This commit is contained in:

Konrad Dybcio

2024-03-09 14:15:03 +01:00

committed by

Roxana Nicolescu

parent 9cc2f9f165

commit 80d87477be

1 changed files with 3 additions and 0 deletions

									
										drivers/thermal/qcom/lmh.c
									
		+3
		
												View File
												
				@@ -95,6 +95,9 @@ static int lmh_probe(struct platform_device *pdev)

					unsigned int enable_alg;

					u32 node_id;

					if (!qcom_scm_is_available())

						return -EPROBE_DEFER;

					lmh_data = devm_kzalloc(dev, sizeof(*lmh_data), GFP_KERNEL);

					if (!lmh_data)

						return -ENOMEM;