powerpc/powernv: Free name on error in opal_event_init()

BugLink: https://bugs.launchpad.net/bugs/2100894

[ Upstream commit cf8989d20d64ad702a6210c11a0347ebf3852aa7 ]

In opal_event_init() if request_irq() fails name is not freed, leading
to a memory leak. The code only runs at boot time, there's no way for a
user to trigger it, so there's no security impact.

Fix the leak by freeing name in the error path.

Reported-by: 2639161967 <2639161967@qq.com>
Closes: https://lore.kernel.org/linuxppc-dev/87wmjp3wig.fsf@mail.lhotse
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://patch.msgid.link/20240920093520.67997-1-mpe@ellerman.id.au
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

This commit is contained in:

Michael Ellerman

2024-09-20 19:35:20 +10:00

committed by

Stefan Bader

parent 4aaf31ea50

commit 7dd189322b

1 changed files with 1 additions and 0 deletions

									
										arch/powerpc/platforms/powernv/opal-irqchip.c
									
		+1
		
												View File
												
				@@ -282,6 +282,7 @@ int __init opal_event_init(void)

								 name, NULL);

						if (rc) {

							pr_warn("Error %d requesting OPAL irq %d\n", rc, (int)r->start);

							kfree(name);

							continue;

						}

					}