octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dmac_flt.c
BugLink: https://bugs.launchpad.net/bugs/2101915 [ Upstream commit f5b942e6c54b13246ee49d42dcfb71b7f29e3c64 ] Add error pointer checks after calling otx2_mbox_get_rsp(). Fixes:79d2be385e("octeontx2-pf: offload DMAC filters to CGX/RPM block") Fixes:fa5e0ccb8f("octeontx2-pf: Add support for exact match table.") Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Sasha Levin <sashal@kernel.org> CVE-2024-56707 Signed-off-by: Koichiro Den <koichiro.den@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
This commit is contained in:
committed by
Stefan Bader
parent
ab916cf68c
commit
67aa80f8d9
@@ -28,6 +28,11 @@ static int otx2_dmacflt_do_add(struct otx2_nic *pf, const u8 *mac,
|
||||
if (!err) {
|
||||
rsp = (struct cgx_mac_addr_add_rsp *)
|
||||
otx2_mbox_get_rsp(&pf->mbox.mbox, 0, &req->hdr);
|
||||
if (IS_ERR(rsp)) {
|
||||
mutex_unlock(&pf->mbox.lock);
|
||||
return PTR_ERR(rsp);
|
||||
}
|
||||
|
||||
*dmac_index = rsp->index;
|
||||
}
|
||||
|
||||
@@ -200,6 +205,10 @@ int otx2_dmacflt_update(struct otx2_nic *pf, u8 *mac, u32 bit_pos)
|
||||
|
||||
rsp = (struct cgx_mac_addr_update_rsp *)
|
||||
otx2_mbox_get_rsp(&pf->mbox.mbox, 0, &req->hdr);
|
||||
if (IS_ERR(rsp)) {
|
||||
rc = PTR_ERR(rsp);
|
||||
goto out;
|
||||
}
|
||||
|
||||
pf->flow_cfg->bmap_to_dmacindex[bit_pos] = rsp->index;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user