perf script: Show also errors for --insn-trace option

BugLink: https://bugs.launchpad.net/bugs/2074091

commit d4a98b45fbe6d06f4b79ed90d0bb05ced8674c23 upstream.

The trace could be misleading if trace errors are not taken into
account, so display them also by adding the itrace "e" option.

Note --call-trace and --call-ret-trace already add the itrace "e"
option.

Fixes: b585ebdb59 ("perf script: Add --insn-trace for instruction decoding")
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240315071334.3478-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Portia Stephens <portia.stephens@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>

This commit is contained in:

Adrian Hunter

2024-03-15 09:13:33 +02:00

committed by

Roxana Nicolescu

parent 6591e7d8be

commit 658b0e92e6

1 changed files with 1 additions and 1 deletions

									
										tools/perf/builtin-script.c
									
		+1
		-1
	
												View File
												
				@@ -3769,7 +3769,7 @@ static int parse_insn_trace(const struct option *opt __maybe_unused,

							    int unset __maybe_unused)

				{

					parse_output_fields(NULL, "+insn,-event,-period", 0);

					itrace_parse_synth_opts(opt, "i0ns", 0);

					itrace_parse_synth_opts(opt, "i0nse", 0);

					symbol_conf.nanosecs = true;

					return 0;

				}