mctp i2c: handle NULL header address

BugLink: https://bugs.launchpad.net/bugs/2099996

[ Upstream commit 01e215975fd80af81b5b79f009d49ddd35976c13 ]

daddr can be NULL if there is no neighbour table entry present,
in that case the tx packet should be dropped.

saddr will usually be set by MCTP core, but check for NULL in case a
packet is transmitted by a different protocol.

Fixes: f5b8abf9fc ("mctp i2c: MCTP I2C binding driver")
Cc: stable@vger.kernel.org
Reported-by: Dung Cao <dung@os.amperecomputing.com>
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241022-mctp-i2c-null-dest-v3-1-e929709956c5@codeconstruct.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
CVE-2024-53043
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

This commit is contained in:

Matt Johnston

2025-02-25 22:59:22 +09:00

committed by

Stefan Bader

parent d72ee055a6

commit 5ee2c6a771

1 changed files with 3 additions and 0 deletions

									
										drivers/net/mctp/mctp-i2c.c
									
		+3
		
												View File
												
				@@ -547,6 +547,9 @@ static int mctp_i2c_header_create(struct sk_buff *skb, struct net_device *dev,

					if (len > MCTP_I2C_MAXMTU)

						return -EMSGSIZE;

					if (!daddr || !saddr)

						return -EINVAL;

					lldst = *((u8 *)daddr);

					llsrc = *((u8 *)saddr);