tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: nuvoton: Fix sgpio irq handle error

Browse Source 
BugLink: https://bugs.launchpad.net/bugs/2071621

[ Upstream commit 7f45fe2ea3b8c85787976293126a4a7133b107de ]

The generic_handle_domain_irq() function calls irq_resolve_mapping().
Thus delete a duplicative irq_find_mapping() call
so that a stack trace and an RCU stall will be avoided.

Fixes: c4f8457d17 ("gpio: nuvoton: Add Nuvoton NPCM sgpio driver")
Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240506064244.1645922-1-JJLIU0@nuvoton.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
This commit is contained in:
Jim Liu
2024-05-06 14:42:44 +08:00
committed by Stefan Bader
parent e1861b7841
commit 5953da6fc6
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/gpio/gpio-npcm-sgpio.c
+4 -6
View File
@@ -434,7 +434,7 @@ static void npcm_sgpio_irq_handler(struct irq_desc *desc)
struct gpio_chip *gc = irq_desc_get_handler_data(desc);
struct irq_chip *ic = irq_desc_get_chip(desc);
struct npcm_sgpio *gpio = gpiochip_get_data(gc);
unsigned int i, j, girq;
unsigned int i, j;
unsigned long reg;
chained_irq_enter(ic, desc);
@@ -443,11 +443,9 @@ static void npcm_sgpio_irq_handler(struct irq_desc *desc)
const struct npcm_sgpio_bank *bank = &npcm_sgpio_banks[i];
reg = ioread8(bank_reg(gpio, bank, EVENT_STS));
for_each_set_bit(j, &reg, 8) {
girq = irq_find_mapping(gc->irq.domain,
i * 8 + gpio->nout_sgpio + j);
generic_handle_domain_irq(gc->irq.domain, girq);
}
for_each_set_bit(j, &reg, 8)
generic_handle_domain_irq(gc->irq.domain,
i * 8 + gpio->nout_sgpio + j);
}
chained_irq_exit(ic, desc);