media: mgb4: protect driver against spectre
BugLink: https://bugs.launchpad.net/bugs/2100292
commit 2aee207e5b3c94ef859316008119ea06d6798d49 upstream.
Frequency range is set from sysfs via frequency_range_store(),
being vulnerable to spectre, as reported by smatch:
drivers/media/pci/mgb4/mgb4_cmt.c:231 mgb4_cmt_set_vin_freq_range() warn: potential spectre issue 'cmt_vals_in' [r]
drivers/media/pci/mgb4/mgb4_cmt.c:238 mgb4_cmt_set_vin_freq_range() warn: possible spectre second half. 'reg_set'
Fix it.
Fixes: 0ab13674a9 ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver")
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Martin Tůma <martin.tuma@digiteqautomotive.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[koichiroden: added #include <linux/nospec.h>]
CVE-2024-53062
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
This commit is contained in:
committed by
Stefan Bader
parent
cdb221ebc2
commit
5443d1dd7e
@@ -12,6 +12,7 @@
|
||||
|
||||
#include <linux/types.h>
|
||||
#include <linux/kernel.h>
|
||||
#include <linux/nospec.h>
|
||||
#include "mgb4_core.h"
|
||||
#include "mgb4_cmt.h"
|
||||
|
||||
@@ -227,6 +228,8 @@ void mgb4_cmt_set_vin_freq_range(struct mgb4_vin_dev *vindev,
|
||||
u32 config;
|
||||
size_t i;
|
||||
|
||||
freq_range = array_index_nospec(freq_range, ARRAY_SIZE(cmt_vals_in));
|
||||
|
||||
addr = cmt_addrs_in[vindev->config->id];
|
||||
reg_set = cmt_vals_in[freq_range];
|
||||
|
||||
|
||||
Reference in New Issue
Block a user