fbdev: xen-fbfront: Assign fb_info->device

BugLink: https://bugs.launchpad.net/bugs/2089340

commit c2af2a45560bd4046c2e109152acde029ed0acc2 upstream.

Probing xen-fbfront faults in video_is_primary_device().  The passed-in
struct device is NULL since xen-fbfront doesn't assign it and the
memory is kzalloc()-ed.  Assign fb_info->device to avoid this.

This was exposed by the conversion of fb_is_primary_device() to
video_is_primary_device() which dropped a NULL check for struct device.

Fixes: f178e96de7f0 ("arch: Remove struct fb_info from video helpers")
Reported-by: Arthur Borsboom <arthurborsboom@gmail.com>
Closes: https://lore.kernel.org/xen-devel/CALUcmUncX=LkXWeiSiTKsDY-cOe8QksWhFvcCneOKfrKd0ZajA@mail.gmail.com/
Tested-by: Arthur Borsboom <arthurborsboom@gmail.com>
CC: stable@vger.kernel.org
Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Portia Stephens <portia.stephens@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

This commit is contained in:

Jason Andryuk

2024-09-09 22:09:16 -04:00

committed by

Mehmet Basaran

parent e856fecf1a

commit 5434fdcb0e

1 changed files with 1 additions and 0 deletions

									
										drivers/video/fbdev/xen-fbfront.c
									
		+1
		
												View File
												
				@@ -407,6 +407,7 @@ static int xenfb_probe(struct xenbus_device *dev,

					/* complete the abuse: */

					fb_info->pseudo_palette = fb_info->par;

					fb_info->par = info;

					fb_info->device = &dev->dev;

					fb_info->screen_buffer = info->fb;