net: test: Fix printf format specifier in skb_segment kunit test

BugLink: https://bugs.launchpad.net/bugs/2060097

[ Upstream commit ff3b96f2c9e5c24fca12239cd519a8a18569e687 ]

KUNIT_FAIL() accepts a printf-style format string, but previously did
not let gcc validate it with the __printf() attribute. The use of %lld
for the result of PTR_ERR() is not correct.

Instead, use %pe and pass the actual error pointer. printk() will format
it correctly (and give a symbolic name rather than a number if
available, which should make the output more readable, too).

Fixes: b3098d32ed ("net: add skb_segment kunit test")
Signed-off-by: David Gow <davidgow@google.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit be63556e8c0ec74385d191f3d5b1cba9c495e182)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

This commit is contained in:

David Gow

2024-02-21 17:27:19 +08:00

committed by

Roxana Nicolescu

parent 788bed8284

commit 431326b867

1 changed files with 1 additions and 1 deletions

									
										net/core/gso_test.c
									
		+1
		-1
	
												View File
												
				@@ -225,7 +225,7 @@ static void gso_test_func(struct kunit *test)

					segs = skb_segment(skb, features);

					if (IS_ERR(segs)) {

						KUNIT_FAIL(test, "segs error %lld", PTR_ERR(segs));

						KUNIT_FAIL(test, "segs error %pe", segs);

						goto free_gso_skb;

					} else if (!segs) {

						KUNIT_FAIL(test, "no segments");