pinctrl: samsung: fix fwnode refcount cleanup if platform_get_irq_optional() fails

BugLink: https://bugs.launchpad.net/bugs/2114239

commit 459915f55509f4bfd6076daa1428e28490ddee3b upstream.

Commit 50ebd19e35 ("pinctrl: samsung: drop pin banks references on
error paths") fixed the pin bank references on the error paths of the
probe function, but there is still an error path where this is not done.

If samsung_pinctrl_get_soc_data() does not fail, the child references
will have acquired, and they will need to be released in the error path
of platform_get_irq_optional(), as it is done in the following error
paths within the probe function.

Replace the direct return in the error path with a goto instruction to
the cleanup function.

Cc: stable@vger.kernel.org
Fixes: a382d568f1 ("pinctrl: samsung: Use platform_get_irq_optional() to get the interrupt")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20241106-samsung-pinctrl-put-v1-1-de854e26dd03@gmail.com
[krzysztof: change Fixes SHA to point to commit introducing the return
 leading to OF node leak]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Noah Wager <noah.wager@canonical.com>
Signed-off-by: Mehmet Basaran <mehmet.basaran@canonical.com>

This commit is contained in:

Javier Carrasco

2024-11-06 23:04:39 +01:00

committed by

Mehmet Basaran

parent 855142dfd8

commit 3f035e9c51

1 changed files with 1 additions and 1 deletions

									
										drivers/pinctrl/samsung/pinctrl-samsung.c
									
		+1
		-1
	
												View File
												
				@@ -1151,7 +1151,7 @@ static int samsung_pinctrl_probe(struct platform_device *pdev)

					ret = platform_get_irq_optional(pdev, 0);

					if (ret < 0 && ret != -ENXIO)

						return ret;

						goto err_put_banks;

					if (ret > 0)

						drvdata->irq = ret;