tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

irqchip/gic-v3-its: Avoid explicit cpumask allocation on stack

Browse Source 
BugLink: https://bugs.launchpad.net/bugs/2102118

In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.

Remove cpumask var on stack and use cpumask_any_and() to address it.

Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20240416085454.3547175-4-dawei.li@shingroup.cn
(cherry picked from commit fcb8af4cbcd122e33ceeadd347b8866d32035af7)
[koichiroden: pulled in prereq commit from mainline (v6.10-rc1~185^2~5)]
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
This commit is contained in:
Dawei Li
2025-03-12 22:51:00 +09:00
committed by Stefan Bader
parent 7da9b21b42
commit 39cbe3e63d
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/irqchip/irq-gic-v3-its.c
+10 -5
View File
@@ -3812,9 +3812,9 @@ static int its_vpe_set_affinity(struct irq_data *d,
bool force)
{
struct its_vpe *vpe = irq_data_get_irq_chip_data(d);
struct cpumask common, *table_mask;
unsigned int from, cpu = nr_cpu_ids;
struct cpumask *table_mask;
unsigned long flags;
int from, cpu;
/*
* Check if we're racing against a VPE being destroyed, for
@@ -3843,10 +3843,15 @@ static int its_vpe_set_affinity(struct irq_data *d,
* If we are offered another CPU in the same GICv4.1 ITS
* affinity, pick this one. Otherwise, any CPU will do.
*/
if (table_mask && cpumask_and(&common, mask_val, table_mask))
cpu = cpumask_test_cpu(from, &common) ? from : cpumask_first(&common);
else
if (table_mask)
cpu = cpumask_any_and(mask_val, table_mask);
if (cpu < nr_cpu_ids) {
if (cpumask_test_cpu(from, mask_val) &&
cpumask_test_cpu(from, table_mask))
cpu = from;
} else {
cpu = cpumask_first(mask_val);
}
if (from == cpu)
goto out;