drm/amd/display: Add NULL check for function pointer in dcn32_set_output_transfer_func

BugLink: https://bugs.launchpad.net/bugs/2089884

[ Upstream commit 28574b08c70e56d34d6f6379326a860b96749051 ]

This commit adds a null check for the set_output_gamma function pointer
in the dcn32_set_output_transfer_func function. Previously,
set_output_gamma was being checked for null, but then it was being
dereferenced without any null check. This could lead to a null pointer
dereference if set_output_gamma is null.

To fix this, we now ensure that set_output_gamma is not null before
dereferencing it. We do this by adding a null check for set_output_gamma
before the call to set_output_gamma.

Cc: Tom Chung <chiahsuan.chung@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Roman Li <roman.li@amd.com>
Cc: Alex Hung <alex.hung@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Tom Chung <chiahsuan.chung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>

This commit is contained in:

Srinivasan Shanmugam

2024-07-31 13:15:00 +05:30

committed by

Mehmet Basaran

parent 74701704d4

commit 397f1a892b

1 changed files with 3 additions and 1 deletions

									
										drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
									
		+3
		-1
	
												View File
												
				@@ -584,7 +584,9 @@ bool dcn32_set_output_transfer_func(struct dc *dc,

						}

					}

					mpc->funcs->set_output_gamma(mpc, mpcc_id, params);

					if (mpc->funcs->set_output_gamma)

						mpc->funcs->set_output_gamma(mpc, mpcc_id, params);

					return ret;

				}