iio: inkern: call iio_device_put() only on mapped devices

BugLink: https://bugs.launchpad.net/bugs/2106770

commit 64f43895b4457532a3cc524ab250b7a30739a1b1 upstream.

In the error path of iio_channel_get_all(), iio_device_put() is called
on all IIO devices, which can cause a refcount imbalance. Fix this error
by calling iio_device_put() only on IIO devices whose refcounts were
previously incremented by iio_device_get().

Fixes: 314be14bb8 ("iio: Rename _st_ functions to loose the bit that meant the staging version.")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://patch.msgid.link/20241204111342.1246706-1-joe@pf.is.s.u-tokyo.ac.jp
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com>
Signed-off-by: Mehmet Basaran <mehmet.basaran@canonical.com>

This commit is contained in:

Joe Hattori

2024-12-04 20:13:42 +09:00

committed by

Mehmet Basaran

parent a9891a2196

commit 38f17e6d95

1 changed files with 1 additions and 1 deletions

									
										drivers/iio/inkern.c
									
		+1
		-1
	
												View File
												
				@@ -514,7 +514,7 @@ struct iio_channel *iio_channel_get_all(struct device *dev)

					return chans;

				error_free_chans:

					for (i = 0; i < nummaps; i++)

					for (i = 0; i < mapind; i++)

						iio_device_put(chans[i].indio_dev);

					kfree(chans);

				error_ret: