tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

printk: nbcon: Remove return value for write_atomic()

Browse Source 
BugLink: https://bugs.launchpad.net/bugs/2060704

The return value of write_atomic() does not provide any useful
information. On the contrary, it makes things more complicated
for the caller to appropriately deal with the information.

Change write_atomic() to not have a return value. If the
message did not get printed due to loss of ownership, the
caller will notice this on its own. If ownership was not lost,
it will be assumed that the driver successfully printed the
message and the sequence number for that console will be
incremented.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Kevin Becker <kevin.becker@canonical.com>
This commit is contained in:
John Ogness
2023-10-20 09:52:59 +00:00
committed by Kevin Becker
parent 2f7e3adeeb
commit 35c935ae72
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/linux/console.h
+1 -1
View File
@@ -327,7 +327,7 @@ struct console {
struct hlist_node node;
/* nbcon console specific members */
bool (*write_atomic)(struct console *con,
void (*write_atomic)(struct console *con,
struct nbcon_write_context *wctxt);
atomic_t __private nbcon_state;
atomic_long_t __private nbcon_seq;
kernel/printk/nbcon.c
+7 -8
View File
@@ -849,7 +849,6 @@ static bool nbcon_emit_next_record(struct nbcon_write_context *wctxt)
unsigned long con_dropped;
struct nbcon_state cur;
unsigned long dropped;
bool done;
/*
* The printk buffers are filled within an unsafe section. This
@@ -889,16 +888,16 @@ static bool nbcon_emit_next_record(struct nbcon_write_context *wctxt)
wctxt->unsafe_takeover = cur.unsafe_takeover;
if (con->write_atomic) {
done = con->write_atomic(con, wctxt);
con->write_atomic(con, wctxt);
} else {
nbcon_context_release(ctxt);
/*
* This function should never be called for legacy consoles.
* Handle it as if ownership was lost and try to continue.
*/
WARN_ON_ONCE(1);
done = false;
}
/* If not done, the emit was aborted. */
if (!done)
nbcon_context_release(ctxt);
return false;
}
/*
* Since any dropped message was successfully output, reset the