tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ravb: Make it clear the information relates to maximum frame size

Browse Source 
BugLink: https://bugs.launchpad.net/bugs/2097301

The struct member rx_max_buf_size was added before split descriptor
support was added. It is unclear if the value describes the full skb
frame buffer or the data descriptor buffer which can be combined into a
single skb.

Rename it to make it clear it referees to the maximum frame size and can
cover multiple descriptors.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Paul Barker <paul.barker.ct@bp.renesas.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit e82700b8662ce5470ebefebc4dc40949f6b14627)
[diewald: prerequisite commit for ec8234717db85 net: ravb: Fix R-Car RX
frame size limit]
Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com>
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
This commit is contained in:
Niklas Söderlund
2024-03-04 12:08:54 +01:00
committed by Mehmet Basaran
parent b97e3b54c2
commit 33ed42ed92
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/ethernet/renesas/ravb.h
+1 -1
View File
@@ -1028,7 +1028,7 @@ struct ravb_hw_info {
size_t max_rx_len;
u32 tccr_mask;
u32 tx_max_frame_size;
u32 rx_max_buf_size;
u32 rx_max_frame_size;
unsigned aligned_tx: 1;
/* hardware features */
drivers/net/ethernet/renesas/ravb_main.c
+4 -4
View File
@@ -2438,7 +2438,7 @@ static const struct ravb_hw_info ravb_gen3_hw_info = {
.max_rx_len = RX_BUF_SZ + RAVB_ALIGN - 1,
.tccr_mask = TCCR_TSRQ0 | TCCR_TSRQ1 | TCCR_TSRQ2 | TCCR_TSRQ3,
.tx_max_frame_size = SZ_2K,
.rx_max_buf_size = SZ_2K,
.rx_max_frame_size = SZ_2K,
.internal_delay = 1,
.tx_counters = 1,
.multi_irqs = 1,
@@ -2465,7 +2465,7 @@ static const struct ravb_hw_info ravb_gen2_hw_info = {
.max_rx_len = RX_BUF_SZ + RAVB_ALIGN - 1,
.tccr_mask = TCCR_TSRQ0 | TCCR_TSRQ1 | TCCR_TSRQ2 | TCCR_TSRQ3,
.tx_max_frame_size = SZ_2K,
.rx_max_buf_size = SZ_2K,
.rx_max_frame_size = SZ_2K,
.aligned_tx = 1,
.gptp = 1,
.nc_queues = 1,
@@ -2488,7 +2488,7 @@ static const struct ravb_hw_info ravb_rzv2m_hw_info = {
.stats_len = ARRAY_SIZE(ravb_gstrings_stats),
.max_rx_len = RX_BUF_SZ + RAVB_ALIGN - 1,
.tccr_mask = TCCR_TSRQ0 | TCCR_TSRQ1 | TCCR_TSRQ2 | TCCR_TSRQ3,
.rx_max_buf_size = SZ_2K,
.rx_max_frame_size = SZ_2K,
.multi_irqs = 1,
.err_mgmt_irqs = 1,
.gptp = 1,
@@ -2512,7 +2512,7 @@ static const struct ravb_hw_info gbeth_hw_info = {
.max_rx_len = ALIGN(GBETH_RX_BUFF_MAX, RAVB_ALIGN),
.tccr_mask = TCCR_TSRQ0,
.tx_max_frame_size = 1522,
.rx_max_buf_size = SZ_8K,
.rx_max_frame_size = SZ_8K,
.aligned_tx = 1,
.tx_counters = 1,
.carrier_counters = 1,