scsi: qla2xxx: Fix double free of the ha->vp_map pointer

BugLink: https://bugs.launchpad.net/bugs/2060531

commit e288285d47784fdcf7c81be56df7d65c6f10c58b upstream.

Coverity scan reported potential risk of double free of the pointer
ha->vp_map.  ha->vp_map was freed in qla2x00_mem_alloc(), and again freed
in function qla2x00_mem_free(ha).

Assign NULL to vp_map and kfree take care of NULL.

Cc: stable@vger.kernel.org
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240227164127.36465-8-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

This commit is contained in:

Saurav Kashyap

2024-02-27 22:11:23 +05:30

committed by

Roxana Nicolescu

parent 36a5ade7eb

commit 30c8329b3a

1 changed files with 1 additions and 0 deletions

									
										drivers/scsi/qla2xxx/qla_os.c
									
		+1
		
												View File
												
				@@ -4602,6 +4602,7 @@ fail_free_init_cb:

					ha->init_cb_dma = 0;

				fail_free_vp_map:

					kfree(ha->vp_map);

					ha->vp_map = NULL;

				fail:

					ql_log(ql_log_fatal, NULL, 0x0030,

					    "Memory allocation failure.\n");