fbdev: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more. Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
committed by
Helge Deller
parent
44a3b36b42
commit
29413f05fe
@@ -854,7 +854,7 @@ static struct clcd_board *clcdfb_of_get_board(struct amba_device *dev)
|
||||
board->caps = CLCD_CAP_ALL;
|
||||
board->check = clcdfb_check;
|
||||
board->decode = clcdfb_decode;
|
||||
if (of_find_property(node, "memory-region", NULL)) {
|
||||
if (of_property_present(node, "memory-region")) {
|
||||
board->setup = clcdfb_of_vram_setup;
|
||||
board->mmap = clcdfb_of_vram_mmap;
|
||||
board->remove = clcdfb_of_vram_remove;
|
||||
|
||||
@@ -306,7 +306,7 @@ static int bw2_probe(struct platform_device *op)
|
||||
if (!par->regs)
|
||||
goto out_release_fb;
|
||||
|
||||
if (!of_find_property(dp, "width", NULL)) {
|
||||
if (!of_property_present(dp, "width")) {
|
||||
err = bw2_do_default_mode(par, info, &linebytes);
|
||||
if (err)
|
||||
goto out_unmap_regs;
|
||||
|
||||
@@ -393,7 +393,7 @@ static int cg3_probe(struct platform_device *op)
|
||||
|
||||
cg3_blank(FB_BLANK_UNBLANK, info);
|
||||
|
||||
if (!of_find_property(dp, "width", NULL)) {
|
||||
if (!of_property_present(dp, "width")) {
|
||||
err = cg3_do_default_mode(par);
|
||||
if (err)
|
||||
goto out_unmap_screen;
|
||||
|
||||
@@ -192,7 +192,7 @@ static int __init omapdss_boot_init(void)
|
||||
omapdss_walk_device(dss, true);
|
||||
|
||||
for_each_available_child_of_node(dss, child) {
|
||||
if (!of_find_property(child, "compatible", NULL))
|
||||
if (!of_property_present(child, "compatible"))
|
||||
continue;
|
||||
|
||||
omapdss_walk_device(child, true);
|
||||
|
||||
Reference in New Issue
Block a user