igb: Fix potential invalid memory access in igb_init_module()

BugLink: https://bugs.launchpad.net/bugs/2102118

[ Upstream commit 0566f83d206c7a864abcd741fe39d6e0ae5eef29 ]

The pci_register_driver() can fail and when this happened, the dca_notifier
needs to be unregistered, otherwise the dca_notifier can be called when
igb fails to install, resulting to invalid memory access.

Fixes: bbd98fe48a ("igb: Fix DCA errors and do not use context index for 82576")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
CVE-2024-52332
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

This commit is contained in:

Yuan Can

2025-03-12 22:51:00 +09:00

committed by

Stefan Bader

parent da38402a22

commit 22fad023c4

1 changed files with 4 additions and 0 deletions

									
										drivers/net/ethernet/intel/igb/igb_main.c
									
		+4
		
												View File
												
				@@ -665,6 +665,10 @@ static int __init igb_init_module(void)

					dca_register_notify(&dca_notifier);

				#endif

					ret = pci_register_driver(&igb_driver);

				#ifdef CONFIG_IGB_DCA

					if (ret)

						dca_unregister_notify(&dca_notifier);

				#endif

					return ret;

				}