tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf: Don't disable preemption in perf_pending_task().

Browse Source 
BugLink: https://bugs.launchpad.net/bugs/2089700

perf_pending_task() is invoked in task context and disables preemption
because perf_swevent_get_recursion_context() used to access per-CPU
variables. The other reason is to create a RCU read section while
accessing the perf_event.

The recursion counter is no longer a per-CPU accounter so disabling
preemption is no longer required. The RCU section is needed and must be
created explicit.

Replace the preemption-disable section with a explicit RCU-read section.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Marco Elver <elver@google.com>
Link: https://lore.kernel.org/r/20240704170424.1466941-7-bigeasy@linutronix.de
(cherry picked from 16b9569df9d2ab07eeee075cb7895e9d3e08e8f0)
Signed-off-by: Kevin Becker <kevin.becker@canonical.com>
Acked-by: Magali Lemes <magali.lemes@canonical.com>
Acked-by: John Cabaj <john.cabaj@canonical.com>
This commit is contained in:
Sebastian Andrzej Siewior
2024-07-04 19:03:40 +02:00
committed by Kevin Becker
parent c51fa128d4
commit 1e4adc1dfa
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
kernel/events/core.c
+5 -6
View File
@@ -5203,10 +5203,9 @@ static void perf_pending_task_sync(struct perf_event *event)
}
/*
* All accesses related to the event are within the same
* non-preemptible section in perf_pending_task(). The RCU
* grace period before the event is freed will make sure all
* those accesses are complete by then.
* All accesses related to the event are within the same RCU section in
* perf_pending_task(). The RCU grace period before the event is freed
* will make sure all those accesses are complete by then.
*/
rcuwait_wait_event(&event->pending_work_wait, !event->pending_work, TASK_UNINTERRUPTIBLE);
}
@@ -6852,7 +6851,7 @@ static void perf_pending_task(struct callback_head *head)
* critical section as the ->pending_work reset. See comment in
* perf_pending_task_sync().
*/
preempt_disable_notrace();
rcu_read_lock();
/*
* If we 'fail' here, that's OK, it means recursion is already disabled
* and we won't recurse 'further'.
@@ -6865,10 +6864,10 @@ static void perf_pending_task(struct callback_head *head)
local_dec(&event->ctx->nr_pending);
rcuwait_wake_up(&event->pending_work_wait);
}
rcu_read_unlock();
if (rctx >= 0)
perf_swevent_put_recursion_context(rctx);
preempt_enable_notrace();
}
#ifdef CONFIG_GUEST_PERF_EVENTS