tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: gso_test: release each segment individually

Browse Source 
consume_skb() doesn't walk the segment list, so segments other than
the first are leaked.

Move this skb_consume call into the loop.

Cc: Willem de Bruijn <willemb@google.com>
Fixes: b3098d32ed ("net: add skb_segment kunit test")
Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Florian Westphal
2023-10-12 14:02:37 +02:00
committed by David S. Miller
parent a3c2dd9648
commit 1b2d3b45c1
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
net/core/gso_test.c
+9 -5
View File
@@ -144,8 +144,8 @@ KUNIT_ARRAY_PARAM(gso_test, cases, gso_test_case_to_desc);
static void gso_test_func(struct kunit *test)
{
const int shinfo_size = SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
struct sk_buff *skb, *segs, *cur, *next, *last;
const struct gso_test_case *tcase;
struct sk_buff *skb, *segs, *cur;
netdev_features_t features;
struct page *page;
int i;
@@ -236,7 +236,10 @@ static void gso_test_func(struct kunit *test)
goto free_gso_skb;
}
for (cur = segs, i = 0; cur; cur = cur->next, i++) {
last = segs->prev;
for (cur = segs, i = 0; cur; cur = next, i++) {
next = cur->next;
KUNIT_ASSERT_EQ(test, cur->len, sizeof(hdr) + tcase->segs[i]);
/* segs have skb->data pointing to the mac header */
@@ -247,13 +250,14 @@ static void gso_test_func(struct kunit *test)
KUNIT_ASSERT_EQ(test, memcmp(skb_mac_header(cur), hdr, sizeof(hdr)), 0);
/* last seg can be found through segs->prev pointer */
if (!cur->next)
KUNIT_ASSERT_PTR_EQ(test, cur, segs->prev);
if (!next)
KUNIT_ASSERT_PTR_EQ(test, cur, last);
consume_skb(cur);
}
KUNIT_ASSERT_EQ(test, i, tcase->nr_segs);
consume_skb(segs);
free_gso_skb:
consume_skb(skb);
}