ksmbd: fix Out-of-Bounds Read in ksmbd_vfs_stream_read

An offset from client could be a negative value, It could lead
to an out-of-bounds read from the stream_buf.
Note that this issue is coming when setting
'vfs objects = streams_xattr parameter' in ksmbd.conf.

Cc: stable@vger.kernel.org # v5.15+
Reported-by: Jordy Zomer <jordyzomer@google.com>
Signed-off-by: Jordy Zomer <jordyzomer@google.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

CVE-2024-56627
(cherry picked from commit fc342cf86e2dc4d2edb0fc2ff5e28b6c7845adb9)
Signed-off-by: Massimiliano Pellizzer <massimiliano.pellizzer@canonical.com>
Acked-by: Koichiro Den <koichiro.den@canonical.com>
Acked-by: Thibault Ferrante <thibault.ferrante@canonical.com>
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>

This commit is contained in:

Jordy Zomer

2025-02-15 17:24:26 +01:00

committed by

Stefan Bader

parent 7e25eab783

commit 1abb7554c8

1 changed files with 4 additions and 0 deletions

									
										fs/smb/server/smb2pdu.c
									
		+4
		
												View File
												
				@@ -6420,6 +6420,10 @@ int smb2_read(struct ksmbd_work *work)

					}

					offset = le64_to_cpu(req->Offset);

					if (offset < 0) {

						err = -EINVAL;

						goto out;

					}

					length = le32_to_cpu(req->Length);

					mincount = le32_to_cpu(req->MinimumCount);