phy: qcom: qmp-usbc: fix NULL-deref on runtime suspend

BugLink: https://bugs.launchpad.net/bugs/2099996

commit 34c21f94fa1e147a19b54b6adf0c93a623b70dd8 upstream.

Commit 413db06c05 ("phy: qcom-qmp-usb: clean up probe initialisation")
removed most users of the platform device driver data from the
qcom-qmp-usb driver, but mistakenly also removed the initialisation
despite the data still being used in the runtime PM callbacks. This bug
was later reproduced when the driver was copied to create the qmp-usbc
driver.

Restore the driver data initialisation at probe to avoid a NULL-pointer
dereference on runtime suspend.

Apparently no one uses runtime PM, which currently needs to be enabled
manually through sysfs, with these drivers.

Fixes: 19281571a4d5 ("phy: qcom: qmp-usb: split USB-C PHY driver")
Cc: stable@vger.kernel.org	# 6.9
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240911115253.10920-4-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CVE-2024-50238
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

This commit is contained in:

Johan Hovold

2025-02-25 22:59:22 +09:00

committed by

Stefan Bader

parent be7024034e

commit 17cf9de8ff

1 changed files with 1 additions and 0 deletions

									
										drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
									
		+1
		
												View File
												
				@@ -1098,6 +1098,7 @@ static int qmp_usbc_probe(struct platform_device *pdev)

						return -ENOMEM;

					qmp->dev = dev;

					dev_set_drvdata(dev, qmp);

					qmp->orientation = TYPEC_ORIENTATION_NORMAL;