net: bcmasp: fix potential memory leak in bcmasp_xmit()

BugLink: https://bugs.launchpad.net/bugs/2097575

[ Upstream commit fed07d3eb8a8d9fcc0e455175a89bc6445d6faed ]

The bcmasp_xmit() returns NETDEV_TX_OK without freeing skb
in case of mapping fails, add dev_kfree_skb() to fix it.

Fixes: 490cb41200 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20241014145901.48940-1-wanghai38@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

This commit is contained in:

Wang Hai

2024-10-14 22:59:01 +08:00

committed by

Stefan Bader

parent 6f42f59e8b

commit 1095db1b17

1 changed files with 1 additions and 0 deletions

									
										drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
									
		+1
		
												View File
												
				@@ -322,6 +322,7 @@ static netdev_tx_t bcmasp_xmit(struct sk_buff *skb, struct net_device *dev)

							}

							/* Rewind so we do not have a hole */

							spb_index = intf->tx_spb_index;

							dev_kfree_skb(skb);

							return NETDEV_TX_OK;

						}