serial: qcom-geni: fix arg types for qcom_geni_serial_poll_bit()

BugLink: https://bugs.launchpad.net/bugs/2089340

[ Upstream commit c2eaf5e01275ae13f1ec5b1434f6c49cfff57430 ]

The "offset" passed in should be unsigned since it's always a positive
offset from our memory mapped IO.

The "field" should be u32 since we're anding it with a 32-bit value
read from the device.

Suggested-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20240610152420.v4.4.I24a0de52dd7336908df180fa6b698e001f3aff82@changeid
Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20240906131336.23625-5-johan+linaro@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stable-dep-of: cc4a0e5754a1 ("serial: qcom-geni: fix console corruption")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Portia Stephens <portia.stephens@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

This commit is contained in:

Douglas Anderson

2024-09-06 15:13:32 +02:00

committed by

Mehmet Basaran

parent 4355b8a03e

commit 0e12679084

1 changed files with 1 additions and 1 deletions

									
										drivers/tty/serial/qcom_geni_serial.c
									
		+1
		-1
	
												View File
												
				@@ -266,7 +266,7 @@ static bool qcom_geni_serial_secondary_active(struct uart_port *uport)

				}

				static bool qcom_geni_serial_poll_bit(struct uart_port *uport,

								int offset, int field, bool set)

								      unsigned int offset, u32 field, bool set)

				{

					u32 reg;

					struct qcom_geni_serial_port *port;