tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform/mellanox: mlxbf-pmc: fix signedness bugs

Browse Source 
BugLink: https://bugs.launchpad.net/bugs/2089884

These need to be signed for the error handling to work.  The
mlxbf_pmc_get_event_num() function returns int so int type is correct.

Fixes: 1ae9ffd303c2 ("platform/mellanox: mlxbf-pmc: Cleanup signed/unsigned mix-up")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/a4af764e-990b-4ebd-b342-852844374032@moroto.mountain
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
(cherry picked from commit 7c8772fef2c25b951660ff31aa1d2174b45af043)
[koichiroden: pulled follow-up fix from upstream]
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
This commit is contained in:
Dan Carpenter
2024-02-29 16:11:36 +03:00
committed by Mehmet Basaran
parent a1ebe8a466
commit 0262eafe28
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/platform/mellanox/mlxbf-pmc.c
+6 -3
View File
@@ -1496,8 +1496,9 @@ static ssize_t mlxbf_pmc_counter_show(struct device *dev,
{
struct mlxbf_pmc_attribute *attr_counter = container_of(
attr, struct mlxbf_pmc_attribute, dev_attr);
unsigned int blk_num, cnt_num, offset;
unsigned int blk_num, cnt_num;
bool is_l3 = false;
int offset;
u64 value;
blk_num = attr_counter->nr;
@@ -1530,9 +1531,10 @@ static ssize_t mlxbf_pmc_counter_store(struct device *dev,
{
struct mlxbf_pmc_attribute *attr_counter = container_of(
attr, struct mlxbf_pmc_attribute, dev_attr);
unsigned int blk_num, cnt_num, offset, data;
unsigned int blk_num, cnt_num, data;
bool is_l3 = false;
u64 evt_num;
int offset;
int err;
blk_num = attr_counter->nr;
@@ -1612,8 +1614,9 @@ static ssize_t mlxbf_pmc_event_store(struct device *dev,
{
struct mlxbf_pmc_attribute *attr_event = container_of(
attr, struct mlxbf_pmc_attribute, dev_attr);
unsigned int blk_num, cnt_num, evt_num;
unsigned int blk_num, cnt_num;
bool is_l3 = false;
int evt_num;
int err;
blk_num = attr_event->nr;