tmakin/ack-tegra
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hwmon: tmp401: Read "ti,n-factor" as signed

Browse Source 
The "ti,n-factor" binding and examples allow negative correction
values. Reading it as u32 makes the helper type disagree with the
documented signed value and hides real schema mismatches.

Use the signed helper so the DT access matches the s32 value stored by
the driver.

Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20260612215332.1889497-1-robh@kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Rob Herring (Arm) authored and Guenter Roeck committed 2026-06-13 05:53:18 -07:00
1 parent 83dda7ed18
commit 9955c92abe
1 file changed
+1 -1
Download Patch File Download Diff File Expand all files Collapse all files
drivers/hwmon/tmp401.c
+1 -1
View File
@@ -560,7 +560,7 @@ static int tmp401_init_client(struct tmp401_data *data)
return ret;
}
ret = of_property_read_u32(data->client->dev.of_node, "ti,n-factor", &nfactor);
ret = of_property_read_s32(data->client->dev.of_node, "ti,n-factor", &nfactor);
if (!ret) {
if (data->kind == tmp401) {
dev_err(&data->client->dev, "ti,tmp401 does not support n-factor correction\n");