tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

UPSTREAM: regulator: pm8008: fix probe failure due to negative voltage selector

Browse Source 
In the current design, the `pm8008_regulator_get_voltage_sel()` callback
can return a negative value if the raw voltage value is read as 0 uV from
the PMIC HW register. This can cause the probe to fail when the
`machine_constraints_voltage()` check is called during the regulator
registration flow.

Fix this by using the helper `regulator_map_voltage_linear_range()` to
convert the raw value to a voltage selector inside the mentioned get
voltage selector function. This ensures that the value returned is always
within the defined range.

Bug: 450452014
Bug: 452256518
Change-Id: Ib895e3ae9107b8e2b4e36cfecea26aace6e1ee80
Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
Message-ID: <20250823-pm8008-negitive-selector-v1-1-52b026a4b5e8@quicinc.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit ef3e9c91ed87f13dba877a20569f4a0accf0612c)
Signed-off-by: Srinivasarao Pathipati <quic_c_spathi@quicinc.com>
(cherry picked from commit a65997387f64d7071954d07fdd30a0443436103a)
This commit is contained in:
Kamal Wadhwa
2025-08-23 01:56:39 +05:30
committed by Treehugger Robot
parent ddd07215be
commit 8c67d4274c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/regulator/qcom-pm8008-regulator.c
+1 -1
View File
@@ -96,7 +96,7 @@ static int pm8008_regulator_get_voltage_sel(struct regulator_dev *rdev)
uV = le16_to_cpu(val) * 1000;
return (uV - preg->desc.min_uV) / preg->desc.uV_step;
return regulator_map_voltage_linear_range(rdev, uV, INT_MAX);
}
static const struct regulator_ops pm8008_regulator_ops = {