tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

UPSTREAM: ALSA: compress_offload: avoid 64-bit get_user()

Browse Source 
On some architectures, get_user() cannot read a 64-bit user variable:

arm-linux-gnueabi-ld: sound/core/compress_offload.o: in function `snd_compr_ioctl':
compress_offload.c:(.text.snd_compr_ioctl+0x538): undefined reference to `__get_user_bad'

Use an equivalent copy_from_user() instead.

Bug: 254441685
Fixes: 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
Acked-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20241216093410.377112-2-arnd@kernel.org
(cherry picked from commit 6018f2fe1089b46c6c9eb136338eca7b16a92331)
Signed-off-by: Lee Jones <joneslee@google.com>
Change-Id: Idcf41a91f840736f86a66ac53e6b6f00d2747982
This commit is contained in:
Arnd Bergmann
2024-12-16 10:33:41 +01:00
committed by Lee Jones
parent e52499905c
commit 81714dce91
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sound/core/compress_offload.c
+3 -3
View File
@@ -1180,9 +1180,9 @@ static int snd_compr_task_seq(struct snd_compr_stream *stream, unsigned long arg
if (stream->runtime->state != SNDRV_PCM_STATE_SETUP)
return -EPERM;
retval = get_user(seqno, (__u64 __user *)arg);
if (retval < 0)
return retval;
retval = copy_from_user(&seqno, (__u64 __user *)arg, sizeof(seqno));
if (retval)
return -EFAULT;
retval = 0;
if (seqno == 0) {
list_for_each_entry_reverse(task, &stream->runtime->tasks, list)