wifi: mwl8k: Use static_assert() to check struct sizes
Commit 5c4250092f ("wifi: mwl8k: Avoid -Wflex-array-member-not-at-end
warnings") introduced tagged `struct mwl8k_cmd_pkt_hdr`. We want to
ensure that when new members need to be added to the flexible structure,
they are always included within this tagged struct.
We use `static_assert()` to ensure that the memory layout for both
the flexible structure and the tagged struct is the same after any
changes.
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/ZrVCg51Q9M2fTPaF@cute
This commit is contained in:
committed by
Kalle Valo
parent
cc32e9fb38
commit
748e21d94a
@@ -587,6 +587,7 @@ static int mwl8k_request_firmware(struct mwl8k_priv *priv, char *fw_image,
|
||||
}
|
||||
|
||||
struct mwl8k_cmd_pkt {
|
||||
/* New members MUST be added within the __struct_group() macro below. */
|
||||
__struct_group(mwl8k_cmd_pkt_hdr, hdr, __packed,
|
||||
__le16 code;
|
||||
__le16 length;
|
||||
@@ -596,6 +597,8 @@ struct mwl8k_cmd_pkt {
|
||||
);
|
||||
char payload[];
|
||||
} __packed;
|
||||
static_assert(offsetof(struct mwl8k_cmd_pkt, payload) == sizeof(struct mwl8k_cmd_pkt_hdr),
|
||||
"struct member likely outside of __struct_group()");
|
||||
|
||||
/*
|
||||
* Firmware loading.
|
||||
|
||||
Reference in New Issue
Block a user