drm/mediatek: Fix child node refcount handling in early exit

commit f708e8b4cfd16e5c8cd8d7fcfcb2fb2c6ed93af3 upstream.

Early exits (goto, break, return) from for_each_child_of_node() required
an explicit call to of_node_put(), which was not introduced with the
break if cnt == MAX_CRTC.

Add the missing of_node_put() before the break.

Cc: stable@vger.kernel.org
Fixes: d761b9450e ("drm/mediatek: Add cnt checking for coverity issue")

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20241011-mtk_drm_drv_memleak-v1-1-2b40c74c8d75@gmail.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

Javier Carrasco

2024-10-11 21:21:51 +02:00

committed by

Greg Kroah-Hartman

parent 22fd2377b9

commit 576fe9345d

1 changed files with 3 additions and 1 deletions

									
										drivers/gpu/drm/mediatek/mtk_drm_drv.c
									
		+3
		-1
	
												View File
												
				@@ -405,8 +405,10 @@ static bool mtk_drm_get_all_drm_priv(struct device *dev)

						if (temp_drm_priv->mtk_drm_bound)

							cnt++;

						if (cnt == MAX_CRTC)

						if (cnt == MAX_CRTC) {

							of_node_put(node);

							break;

						}

					}

					if (drm_priv->data->mmsys_dev_num == cnt) {