tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: vimc: Don't iterate over single pad

Browse Source 
The .init_state() operations of the debayer and sensor entities iterate
over the entity's pads. In practice, the iteration covers a single pad
only. Access the pad directly and remove the loops.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
Laurent Pinchart
2024-04-25 02:57:33 +03:00
committed by Hans Verkuil
parent b6ee5ac184
commit 2ef9a1e722
2 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/media/test-drivers/vimc/vimc-debayer.c
+3 -6
View File
@@ -155,16 +155,13 @@ static int vimc_debayer_init_state(struct v4l2_subdev *sd,
{
struct vimc_debayer_device *vdebayer = v4l2_get_subdevdata(sd);
struct v4l2_mbus_framefmt *mf;
unsigned int i;
mf = v4l2_subdev_state_get_format(sd_state, 0);
*mf = sink_fmt_default;
for (i = 1; i < sd->entity.num_pads; i++) {
mf = v4l2_subdev_state_get_format(sd_state, i);
*mf = sink_fmt_default;
mf->code = vdebayer->src_code;
}
mf = v4l2_subdev_state_get_format(sd_state, 1);
*mf = sink_fmt_default;
mf->code = vdebayer->src_code;
return 0;
}
drivers/media/test-drivers/vimc/vimc-sensor.c
+3 -7
View File
@@ -44,14 +44,10 @@ static const struct v4l2_mbus_framefmt fmt_default = {
static int vimc_sensor_init_state(struct v4l2_subdev *sd,
struct v4l2_subdev_state *sd_state)
{
unsigned int i;
struct v4l2_mbus_framefmt *mf;
for (i = 0; i < sd->entity.num_pads; i++) {
struct v4l2_mbus_framefmt *mf;
mf = v4l2_subdev_state_get_format(sd_state, i);
*mf = fmt_default;
}
mf = v4l2_subdev_state_get_format(sd_state, 0);
*mf = fmt_default;
return 0;
}