tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HID: hid-debug: more informative output for EV_KEY

Browse Source 
Currently hid-debug's hid_resolv_event prints questions marks for
all entries without explicit mapping information. This makes
debugging unnecessarily complicated as multiple different
keys may simply result in the same uninformative output.

Some common event codes are deliberately not defined in
input-event-codes.h. For example the 16th gamepad key.

Instead, print the hexadecimal codes for all events without symbolic
names.

Signed-off-by: Thomas Kuehne <thomas.kuehne@gmx.li>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
This commit is contained in:
Thomas Kuehne
2024-04-13 12:23:30 +00:00
committed by Jiri Kosina
parent 815234a4e7
commit 132ea82493
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/hid/hid-debug.c
+9 -2
View File
@@ -3582,8 +3582,15 @@ static const char **names[EV_MAX + 1] = {
static void hid_resolv_event(__u8 type, __u16 code, struct seq_file *f)
{
seq_printf(f, "%s.%s", events[type] ? events[type] : "?",
names[type] ? (names[type][code] ? names[type][code] : "?") : "?");
if (events[type])
seq_printf(f, "%s.", events[type]);
else
seq_printf(f, "%02x.", type);
if (names[type] && names[type][code])
seq_printf(f, "%s", names[type][code]);
else
seq_printf(f, "%04x", code);
}
static void hid_dump_input_mapping(struct hid_device *hid, struct seq_file *f)