hpet: Optimize local variable data type in hpet_alloc()

The local variable period uses at most 32 bits and can be a u32 instead
of unsigned long. The upper 32 bits are all 0 after masking and right
shifting cap by HPET_COUNTER_CLK_PERIOD_SHIFT and can be discarded.

Since do_div() casts the divisor to u32 anyway, changing the data type
of period to u32 also removes the following Coccinelle/coccicheck
warning reported by do_div.cocci:

  WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240710215238.799239-2-thorsten.blum@toblux.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

Thorsten Blum

2024-07-10 23:52:39 +02:00

committed by

Greg Kroah-Hartman

parent 4d41a49c46

commit 104831a175

1 changed files with 1 additions and 1 deletions

									
										drivers/char/hpet.c
									
		+1
		-1
	
												View File
												
				@@ -808,7 +808,7 @@ int hpet_alloc(struct hpet_data *hdp)

					struct hpets *hpetp;

					struct hpet __iomem *hpet;

					static struct hpets *last;

					unsigned long period;

					u32 period;

					unsigned long long temp;

					u32 remainder;