Linus Torvalds 5336377d62
modules: Fix module_bug_list list corruption race ...
With all the recent module loading cleanups, we've minimized the code
that sits under module_mutex, fixing various deadlocks and making it
possible to do most of the module loading in parallel.
However, that whole conversion totally missed the rather obscure code
that adds a new module to the list for BUG() handling. That code was
doubly obscure because (a) the code itself lives in lib/bugs.c (for
dubious reasons) and (b) it gets called from the architecture-specific
"module_finalize()" rather than from generic code.
Calling it from arch-specific code makes no sense what-so-ever to begin
with, and is now actively wrong since that code isn't protected by the
module loading lock any more.
So this commit moves the "module_bug_{finalize,cleanup}()" calls away
from the arch-specific code, and into the generic code - and in the
process protects it with the module_mutex so that the list operations
are now safe.
Future fixups:
- move the module list handling code into kernel/module.c where it
belongs.
- get rid of 'module_bug_list' and just use the regular list of modules
(called 'modules' - imagine that) that we already create and maintain
for other reasons.
Reported-and-tested-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Rusty Russell <rusty@rustcorp.com.au >
Cc: Adrian Bunk <bunk@kernel.org >
Cc: Andrew Morton <akpm@linux-foundation.org >
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-10-05 11:29:27 -07:00
2010-08-17 22:15:09 +01:00
2010-08-14 22:26:51 +02:00
2010-08-14 22:26:51 +02:00
2010-09-09 18:57:24 -07:00
2010-07-31 02:37:17 -07:00
2010-08-12 10:01:30 -07:00
2010-09-09 18:57:22 -07:00
2010-08-08 21:19:42 +01:00
2010-08-23 18:30:30 -07:00
2010-08-14 22:26:51 +02:00
2010-08-14 22:26:51 +02:00
2010-08-14 22:26:51 +02:00
2010-08-14 22:26:51 +02:00
2010-08-14 22:26:51 +02:00
2010-08-05 13:26:20 +01:00
2010-08-12 06:38:24 +10:00
2010-08-11 11:38:01 +01:00
2010-09-08 10:50:00 -06:00
2010-09-12 19:55:25 -04:00
2010-08-28 13:55:31 -07:00
2010-08-24 13:44:40 -07:00
2010-08-01 19:36:03 -04:00
2010-08-07 18:23:12 +02:00
2010-08-09 00:13:34 +02:00
2010-08-12 08:43:30 -07:00
2010-08-17 18:07:43 -07:00
2010-08-07 18:53:10 +02:00
2010-08-12 08:43:30 -07:00
2010-08-12 08:43:30 -07:00
2010-08-07 18:26:29 +02:00
2010-08-18 01:09:01 -04:00
2010-08-02 15:34:57 +10:00
2010-09-09 18:57:23 -07:00
2010-08-07 18:53:13 +02:00
2010-09-14 16:08:45 -07:00
2010-08-09 20:45:04 -07:00
2010-08-10 13:47:42 -07:00
2010-08-06 15:36:47 -05:00
2010-08-08 14:55:26 -04:00
2010-08-03 13:47:04 -04:00
2010-09-30 21:19:22 -04:00
2010-07-29 15:16:18 -07:00
2010-08-11 00:29:47 -04:00
2010-08-04 11:00:45 +02:00
2010-08-12 04:14:10 +01:00
2010-08-05 13:53:35 -07:00
2010-08-12 04:14:05 +01:00
2010-09-22 17:22:38 -07:00
2010-09-22 15:29:32 -07:00
2010-07-30 09:36:01 -07:00
2010-08-05 17:17:51 +00:00
2010-08-07 18:53:57 +02:00
2010-08-07 18:53:57 +02:00
2010-08-23 13:52:19 +02:00
2010-08-10 00:09:20 -07:00
2010-08-10 11:26:52 -07:00
2010-08-27 19:54:09 -04:00
2010-08-10 13:47:40 -07:00
2010-08-06 09:23:07 -07:00
2010-08-02 10:09:04 +02:00
2010-07-29 23:09:18 +02:00
2010-08-09 20:45:09 -07:00
2010-08-18 08:35:46 -04:00
2010-09-21 17:27:44 -07:00
2010-08-01 17:06:44 -06:00
2010-08-22 20:28:16 -04:00
2010-08-12 14:23:04 -07:00
2010-08-03 19:45:31 -07:00
2010-09-01 08:55:24 -06:00
2010-08-09 20:44:58 -07:00
2010-08-11 09:23:22 +02:00
2010-08-11 09:22:46 +02:00
2010-08-11 18:21:02 +02:00
2010-08-11 18:21:02 +02:00
2010-08-22 21:15:39 -07:00
2010-08-22 21:15:39 -07:00
2010-08-22 21:15:39 -07:00
2010-08-04 15:31:02 -07:00
2010-08-22 21:15:39 -07:00
2010-07-28 10:18:49 -04:00
2010-08-02 20:30:04 -07:00
2010-08-03 09:49:09 -04:00
2010-09-07 11:16:43 +01:00
2010-07-29 13:24:57 +02:00
2010-09-05 14:26:15 +02:00
2010-08-09 20:45:05 -07:00
2010-08-22 21:15:39 -07:00
2010-08-10 13:47:40 -07:00
2010-08-07 13:03:53 -07:00
2010-08-10 11:49:21 -07:00
2010-08-12 11:27:58 +02:00
2010-08-14 22:26:51 +02:00
2010-08-05 09:22:30 -05:00
2010-08-12 09:51:35 -07:00
2010-09-09 18:57:22 -07:00
2010-08-05 09:22:21 -05:00
2010-08-23 18:12:46 -07:00
2010-08-23 18:12:46 -07:00
2010-09-09 18:57:24 -07:00
2010-08-02 06:40:39 +03:00
2010-08-02 06:39:44 +03:00
2010-08-01 10:47:00 +03:00
2010-09-09 09:09:43 -07:00
2010-09-09 22:31:55 -04:00
2010-08-02 15:35:11 +10:00
2010-08-04 11:47:58 -07:00
2010-08-09 16:48:45 -04:00
2010-08-11 08:59:19 -07:00
2010-08-09 20:44:56 -07:00
2010-08-21 00:37:40 -07:00
2010-08-21 08:49:21 -07:00
2010-09-09 09:05:06 -07:00
2010-08-09 20:44:58 -07:00
2010-09-09 18:57:25 -07:00
2010-10-05 11:29:27 -07:00
2010-08-11 23:04:41 +09:30
2010-08-11 00:29:47 -04:00
2010-07-30 09:41:39 -07:00
2010-09-03 08:19:51 +02:00
2010-08-22 21:15:39 -07:00
2010-08-22 21:15:39 -07:00
2010-08-04 15:31:02 -07:00
2010-09-22 13:21:05 -07:00
2010-09-17 16:55:03 -07:00
2010-07-30 14:46:10 -04:00
2010-08-07 13:19:36 -07:00
2010-08-06 13:41:39 -04:00
2010-07-30 14:41:56 -04:00
2010-07-30 14:46:10 -04:00
2010-08-01 01:42:42 -06:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-07-30 00:03:59 -06:00
2010-07-30 00:03:58 -06:00
2010-08-08 10:02:59 -07:00
2010-08-11 08:59:19 -07:00
2010-07-31 19:53:06 +08:00
2010-08-12 10:15:10 -07:00
2010-08-11 00:29:47 -04:00
2010-08-04 14:12:05 -07:00
2010-09-23 16:26:03 +02:00
2010-08-13 16:19:59 -07:00
2010-08-09 20:44:58 -07:00
2010-08-07 14:20:53 +02:00
2010-08-06 09:39:22 -07:00
2010-08-22 21:15:39 -07:00
2010-08-05 13:53:34 -07:00
2010-08-11 09:21:15 +02:00
2010-08-04 21:53:17 -07:00
2010-08-18 23:30:42 -07:00
2010-09-09 16:08:51 +02:00
2010-08-09 20:44:59 -07:00
2010-08-03 09:48:50 -04:00
2010-08-09 16:47:27 -04:00
2010-08-10 11:26:52 -07:00
2010-08-22 21:15:39 -07:00
2010-08-12 10:15:10 -07:00
2010-08-17 18:07:43 -07:00
2010-08-10 12:07:51 -07:00
2010-09-08 15:04:10 +02:00
2010-08-10 13:47:46 -07:00
2010-09-03 17:29:04 -07:00
2010-08-10 13:47:46 -07:00
2010-08-10 13:47:46 -07:00
2010-09-03 17:29:04 -07:00
2010-08-04 16:12:01 +09:00
2010-08-09 20:44:58 -07:00
2010-08-04 21:53:14 -07:00
2010-08-11 08:59:21 -07:00
2010-08-11 08:59:21 -07:00
2010-08-22 10:08:52 -07:00
2010-09-27 20:24:54 -07:00
2010-08-09 16:48:44 -04:00
2010-09-09 18:57:25 -07:00
2010-08-17 18:07:43 -07:00
2010-08-23 18:12:46 -07:00
2010-08-21 00:34:45 -07:00
2010-08-11 08:59:22 -07:00
2010-08-13 16:53:13 -07:00
2010-08-03 09:48:45 -04:00
2010-08-09 20:44:57 -07:00
2010-08-18 08:35:47 -04:00
2010-08-06 10:37:02 -04:00
2010-08-21 00:37:40 -07:00
2010-08-10 14:35:44 -07:00
2010-08-27 09:10:44 +10:00
2010-08-08 23:43:01 -03:00
2010-08-11 08:59:02 -07:00
2010-08-12 09:09:41 -07:00
2010-09-09 18:57:25 -07:00
2010-08-10 13:47:44 -07:00
2010-09-13 10:26:52 +02:00
2010-08-12 08:43:29 -07:00
2010-08-02 15:34:57 +10:00
5336377d62