Tejun Heo 1265057fa0
workqueue: fix CPU binding of flush_delayed_work[_sync]() ...
delayed_work encodes the workqueue to use and the last CPU in
delayed_work->work.data while it's on timer. The target CPU is
implicitly recorded as the CPU the timer is queued on and
delayed_work_timer_fn() queues delayed_work->work to the CPU it is
running on.
Unfortunately, this leaves flush_delayed_work[_sync]() no way to find
out which CPU the delayed_work was queued for when they try to
re-queue after killing the timer. Currently, it chooses the local CPU
flush is running on. This can unexpectedly move a delayed_work queued
on a specific CPU to another CPU and lead to subtle errors.
There isn't much point in trying to save several bytes in struct
delayed_work, which is already close to a hundred bytes on 64bit with
all debug options turned off. This patch adds delayed_work->cpu to
remember the CPU it's queued for.
Note that if the timer is migrated during CPU down, the work item
could be queued to the downed global_cwq after this change. As a
detached global_cwq behaves like an unbound one, this doesn't change
much for the delayed_work.
Signed-off-by: Tejun Heo <tj@kernel.org >
Cc: Linus Torvalds <torvalds@linux-foundation.org >
Cc: Ingo Molnar <mingo@redhat.com >
Cc: Andrew Morton <akpm@linux-foundation.org >
2012-08-13 16:27:55 -07:00
2012-08-01 16:41:07 -07:00
2012-07-17 15:11:37 -04:00
2012-07-20 12:31:05 +02:00
2012-07-30 18:16:01 -07:00
2012-07-30 18:15:23 -07:00
2012-07-17 09:32:14 -07:00
2012-07-31 18:08:25 -07:00
2012-07-10 18:49:26 +01:00
2012-07-24 23:55:03 -07:00
2012-07-27 16:49:22 -04:00
2012-07-30 12:41:17 -07:00
2012-07-24 13:56:26 -07:00
2012-07-24 17:12:54 -07:00
2012-07-04 19:51:50 +02:00
2012-07-31 01:02:51 +04:00
2012-07-03 21:51:08 +02:00
2012-07-31 18:08:25 -07:00
2012-07-31 18:08:25 -07:00
2012-07-22 19:32:00 +01:00
2012-07-26 12:59:53 -07:00
2012-07-31 19:25:39 -07:00
2012-07-26 10:23:47 -07:00
2012-07-30 11:54:53 -07:00
2012-07-30 17:25:21 -07:00
2012-07-20 09:07:37 +01:00
2012-06-29 11:38:17 -04:00
2012-07-29 21:43:08 +04:00
2012-07-31 18:42:40 -07:00
2012-07-31 18:42:47 -07:00
2012-07-31 09:08:15 +02:00
2012-08-01 12:24:18 +02:00
2012-07-11 16:04:49 -07:00
2012-06-25 11:53:48 +02:00
2012-07-04 13:07:05 +02:00
2012-07-17 21:37:27 +02:00
2012-07-31 18:42:43 -07:00
2012-07-11 15:36:43 -07:00
2012-07-11 17:58:46 -07:00
2012-07-30 17:25:11 -07:00
2012-07-31 18:42:42 -07:00
2012-07-30 17:25:21 -07:00
2012-07-19 08:34:37 -07:00
2012-07-17 12:39:26 -07:00
2012-07-26 14:28:55 -07:00
2012-07-27 09:29:42 +09:30
2012-07-24 13:53:22 +02:00
2012-07-14 16:34:14 +04:00
2012-07-27 15:08:16 +01:00
2012-07-26 11:25:33 -07:00
2012-07-27 15:08:16 +01:00
2012-07-30 12:25:47 +02:00
2012-07-30 12:25:46 +02:00
2012-07-19 10:39:00 +02:00
2012-06-27 09:01:30 -03:00
2012-07-16 22:38:27 -07:00
2012-06-27 15:42:24 -07:00
2012-07-17 21:37:27 +02:00
2012-07-22 23:57:58 +04:00
2012-07-30 09:32:39 -07:00
2012-08-01 10:26:23 -07:00
2012-06-28 13:52:15 -04:00
2012-07-24 00:01:30 -07:00
2012-08-01 09:02:41 -07:00
2012-07-31 18:42:46 -07:00
2012-07-05 15:04:10 +02:00
2012-07-09 16:23:33 +02:00
2012-07-31 18:42:47 -07:00
2012-07-11 23:34:39 +02:00
2012-07-31 18:42:41 -07:00
2012-07-31 18:42:50 -07:00
2012-07-14 13:30:25 +02:00
2012-07-30 19:03:41 -07:00
2012-07-02 15:11:12 +02:00
2012-07-20 11:07:00 -07:00
2012-07-20 11:07:00 -07:00
2012-07-18 09:36:12 -07:00
2012-06-30 01:08:00 -07:00
2012-07-26 13:08:01 -07:00
2012-07-27 09:29:42 +09:30
2012-07-07 16:18:33 -07:00
2012-07-19 10:40:42 -04:00
2012-07-11 18:22:32 +10:00
2012-07-23 12:17:00 +02:00
2012-07-18 08:59:58 -07:00
2012-07-22 12:19:36 -07:00
2012-07-19 10:38:32 -04:00
2012-07-11 16:16:00 +01:00
2012-07-06 10:53:49 +02:00
2012-07-30 19:03:41 -07:00
2012-07-30 17:25:14 -07:00
2012-07-21 13:58:17 -07:00
2012-07-30 15:08:46 +10:00
2012-07-02 12:34:23 -07:00
2012-07-21 10:34:00 -07:00
2012-07-22 10:15:28 -07:00
2012-07-24 12:01:20 -07:00
2012-07-24 07:52:34 +08:00
2012-07-25 15:58:48 -04:00
2012-07-23 13:54:52 +01:00
2012-07-23 13:54:52 +01:00
2012-07-01 03:34:50 -07:00
2012-07-11 16:04:50 -07:00
2012-07-31 18:42:48 -07:00
2012-06-25 11:53:47 +02:00
2012-07-31 18:42:40 -07:00
2012-07-01 03:34:50 -07:00
2012-07-19 15:51:36 -04:00
2012-07-31 18:42:45 -07:00
2012-08-01 10:26:23 -07:00
2012-07-31 18:42:46 -07:00
2012-07-03 13:22:37 +08:00
2012-07-29 21:24:13 +04:00
2012-07-22 12:44:01 -07:00
2012-07-20 11:06:59 -07:00
2012-06-29 16:46:06 -07:00
2012-07-17 09:02:36 -07:00
2012-07-09 16:42:24 -04:00
2012-07-30 19:06:52 -04:00
2012-07-31 19:25:39 -07:00
2012-07-30 19:06:52 -04:00
2012-06-28 17:20:50 -04:00
2012-07-30 19:06:52 -04:00
2012-07-30 17:25:19 -07:00
2012-07-17 12:16:39 +02:00
2012-06-26 21:06:11 -07:00
2012-06-25 13:50:28 +02:00
2012-07-10 10:32:06 -05:00
2012-07-31 20:44:03 -07:00
2012-07-31 23:27:30 -04:00
2012-07-31 12:06:20 +01:00
2012-07-31 18:42:45 -07:00
2012-07-31 18:42:43 -07:00
2012-07-31 18:42:45 -07:00
2012-07-31 18:42:45 -07:00
2012-07-31 18:42:47 -07:00
2012-07-22 16:07:45 -07:00
2012-07-26 14:18:18 -07:00
2012-07-23 12:17:00 +02:00
2012-07-09 00:10:56 -07:00
2012-08-01 10:26:23 -07:00
2012-07-12 07:54:46 -07:00
2012-07-05 22:12:32 +02:00
2012-07-19 00:02:30 +02:00
2012-07-26 13:36:43 -07:00
2012-07-13 20:41:58 -07:00
2012-07-08 00:25:48 +10:00
2012-07-30 17:25:14 -07:00
2012-07-17 16:48:09 -07:00
2012-07-17 12:15:30 -07:00
2012-07-23 13:23:52 +02:00
2012-07-22 23:58:19 +04:00
2012-07-22 23:58:19 +04:00
2012-07-19 10:38:32 -04:00
2012-07-06 06:01:49 -07:00
2012-07-02 11:39:19 -07:00
2012-07-22 19:26:07 +01:00
2012-07-15 11:39:01 +03:00
2012-07-04 11:51:59 +03:00
2012-07-10 22:40:13 -07:00
2012-07-30 12:25:44 +02:00
2012-07-31 18:42:45 -07:00
2012-07-26 13:37:02 -07:00
2012-07-20 11:28:20 +05:30
2012-07-10 12:08:14 +09:00
2012-08-01 13:48:52 +09:00
2012-07-30 17:25:20 -07:00
2012-07-31 18:42:43 -07:00
2012-06-28 17:14:34 +01:00
2012-07-31 18:42:46 -07:00
2012-07-02 13:40:06 +03:00
2012-07-09 12:13:35 +03:00
2012-07-19 11:02:03 -07:00
2012-07-16 22:31:34 -07:00
2012-07-19 11:02:03 -07:00
2012-07-30 17:25:16 -07:00
2012-07-01 13:31:23 +02:00
2012-07-31 18:42:47 -07:00
2012-07-22 23:57:56 +04:00
2012-07-23 00:58:46 -07:00
2012-07-31 18:08:25 -07:00
2012-07-10 15:47:46 +02:00
2012-07-26 13:36:43 -07:00
2012-07-13 19:34:43 -04:00
2012-07-22 23:57:55 +04:00
2012-07-06 10:53:49 +02:00
2012-07-22 23:57:56 +04:00
2012-07-20 08:59:00 +01:00
2012-07-16 17:43:04 -07:00
2012-07-06 10:53:20 -07:00
2012-07-06 15:26:45 -03:00
2012-07-06 20:17:46 -03:00
2012-07-06 20:17:46 -03:00
2012-07-31 08:16:24 -06:00
2012-07-30 20:23:11 -03:00
2012-07-30 13:30:52 +09:30
2012-07-30 13:30:49 +09:30
2012-07-20 08:58:58 +01:00
2012-07-20 08:59:03 +01:00
2012-07-31 18:42:46 -07:00
2012-07-30 12:25:45 +02:00
2012-07-31 18:42:50 -07:00
2012-08-13 16:27:55 -07:00
2012-07-31 18:42:40 -07:00
1265057fa0