Gabriel Krisman Bertazi
e97096d89b
BugLink: https://bugs.launchpad.net/bugs/2083196
[ Upstream commit 3e05b222382ec67dce7358d50b6006e91d028d8b ]
io_probe checks io_issue_def->not_supported, but we never really set
that field, as we mark non-supported functions through a specific ->prep
handler. This means we end up returning IO_URING_OP_SUPPORTED, even for
disabled operations. Fix it by just checking the prep handler itself.
Fixes: 66f4af93da ("io_uring: add support for probing opcodes")
Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>
Link: https://lore.kernel.org/r/20240619020620.5301-2-krisman@suse.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Portia Stephens <portia.stephens@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
55 lines
1.5 KiB
C
55 lines
1.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#ifndef IOU_OP_DEF_H
|
|
#define IOU_OP_DEF_H
|
|
|
|
struct io_issue_def {
|
|
/* needs req->file assigned */
|
|
unsigned needs_file : 1;
|
|
/* should block plug */
|
|
unsigned plug : 1;
|
|
/* hash wq insertion if file is a regular file */
|
|
unsigned hash_reg_file : 1;
|
|
/* unbound wq insertion if file is a non-regular file */
|
|
unsigned unbound_nonreg_file : 1;
|
|
/* set if opcode supports polled "wait" */
|
|
unsigned pollin : 1;
|
|
unsigned pollout : 1;
|
|
unsigned poll_exclusive : 1;
|
|
/* op supports buffer selection */
|
|
unsigned buffer_select : 1;
|
|
/* skip auditing */
|
|
unsigned audit_skip : 1;
|
|
/* supports ioprio */
|
|
unsigned ioprio : 1;
|
|
/* supports iopoll */
|
|
unsigned iopoll : 1;
|
|
/* have to be put into the iopoll list */
|
|
unsigned iopoll_queue : 1;
|
|
/* opcode specific path will handle ->async_data allocation if needed */
|
|
unsigned manual_alloc : 1;
|
|
/* vectored opcode, set if 1) vectored, and 2) handler needs to know */
|
|
unsigned vectored : 1;
|
|
|
|
int (*issue)(struct io_kiocb *, unsigned int);
|
|
int (*prep)(struct io_kiocb *, const struct io_uring_sqe *);
|
|
};
|
|
|
|
struct io_cold_def {
|
|
/* size of async data needed, if any */
|
|
unsigned short async_size;
|
|
|
|
const char *name;
|
|
|
|
int (*prep_async)(struct io_kiocb *);
|
|
void (*cleanup)(struct io_kiocb *);
|
|
void (*fail)(struct io_kiocb *);
|
|
};
|
|
|
|
extern const struct io_issue_def io_issue_defs[];
|
|
extern const struct io_cold_def io_cold_defs[];
|
|
|
|
bool io_uring_op_supported(u8 opcode);
|
|
|
|
void io_uring_optable_init(void);
|
|
#endif
|