video: ARM CLCD: export symbols for driver module
The amba-clcd-versatile.c code is always built-in and has to be done that way because it gets called by platform code that is also built-in. However, it now also gets called from the core CLCD driver through the .init_panel callback function, which leads to a build error when the framebuffer is configured as a loadable module: ERROR: "versatile_clcd_init_panel" [drivers/video/fbdev/amba-clcd-mod.ko] undefined! The same thing happens for the nomadik driver, although that could be linked into the core module if we want to: ERROR: "nomadik_clcd_init_panel" [drivers/video/fbdev/amba-clcd.ko] undefined! ERROR: "nomadik_clcd_init_board" [drivers/video/fbdev/amba-clcd.ko] undefined! For consistency, I'm taking the same approach in both cases here and just export the functions to make them usable by the driver. Alternatively, we could split out the CONFIG_OF-code from amba-clcd-versatile.c into a new file and link those two together with the core driver as one module. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes:1d3f0cbe0d("video: ARM CLCD: add special board and panel hooks for Nomadik") Fixes:25348160e9("video: ARM CLCD: add special panel hook for Versatiles") Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
committed by
Tomi Valkeinen
parent
9986908d38
commit
ffe439d644
@@ -231,6 +231,7 @@ int nomadik_clcd_init_panel(struct clcd_fb *fb,
|
|||||||
/* Unknown panel, fall through */
|
/* Unknown panel, fall through */
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
EXPORT_SYMBOL_GPL(nomadik_clcd_init_panel);
|
||||||
|
|
||||||
#define PMU_CTRL_OFFSET 0x0000
|
#define PMU_CTRL_OFFSET 0x0000
|
||||||
#define PMU_CTRL_LCDNDIF BIT(26)
|
#define PMU_CTRL_LCDNDIF BIT(26)
|
||||||
@@ -255,3 +256,4 @@ int nomadik_clcd_init_board(struct amba_device *adev,
|
|||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
EXPORT_SYMBOL_GPL(nomadik_clcd_init_board);
|
||||||
|
|||||||
@@ -571,5 +571,5 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
|
|||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
EXPORT_SYMBOL_GPL(versatile_clcd_init_panel);
|
||||||
#endif
|
#endif
|
||||||
|
|||||||
Reference in New Issue
Block a user