wifi: rtlwifi: pci: wait for firmware loading before releasing memory

BugLink: https://bugs.launchpad.net/bugs/2111953

[ Upstream commit b59b86c5d08be7d761c04affcbcec8184738c200 ]

At probe error path, the firmware loading work may have already been
queued. In such a case, it will try to access memory allocated by the probe
function, which is about to be released. In such paths, wait for the
firmware worker to finish before releasing memory.

Fixes: 3d86b93064 ("rtlwifi: Fix PCI probe error path orphaned memory")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20241206173713.3222187-5-cascardo@igalia.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com>
Signed-off-by: Mehmet Basaran <mehmet.basaran@canonical.com>

This commit is contained in:

Thadeu Lima de Souza Cascardo

2024-12-06 14:37:13 -03:00

committed by

Mehmet Basaran

parent 826950fe7f

commit f4b81c117c

1 changed files with 1 additions and 0 deletions

									
										drivers/net/wireless/realtek/rtlwifi/pci.c
									
		+1
		
												View File
												
				@@ -2218,6 +2218,7 @@ fail5:

				fail4:

					rtl_deinit_core(hw);

				fail3:

					wait_for_completion(&rtlpriv->firmware_loading_complete);

					rtlpriv->cfg->ops->deinit_sw_vars(hw);

				fail2: