From dfb55a78983b7657bac4ab9e0dffa33da01786b6 Mon Sep 17 00:00:00 2001 From: Chao Yu Date: Wed, 7 Aug 2024 18:24:35 +0800 Subject: [PATCH] f2fs: atomic: fix to truncate pagecache before on-disk metadata truncation BugLink: https://bugs.launchpad.net/bugs/2089340 [ Upstream commit ebd3309aec6271c4616573b0cb83ea25e623070a ] We should always truncate pagecache while truncating on-disk data. Fixes: a46bebd502fe ("f2fs: synchronize atomic write aborts") Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin Signed-off-by: Portia Stephens Signed-off-by: Stefan Bader --- fs/f2fs/file.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 9d8f5e27e919..6af403d24577 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -2167,6 +2167,10 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate) F2FS_I(fi->cow_inode)->atomic_inode = inode; } else { /* Reuse the already created COW inode */ + f2fs_bug_on(sbi, get_dirty_pages(fi->cow_inode)); + + invalidate_mapping_pages(fi->cow_inode->i_mapping, 0, -1); + ret = f2fs_do_truncate_blocks(fi->cow_inode, 0, true); if (ret) { f2fs_up_write(&fi->i_gc_rwsem[WRITE]);